Date picker #244

bbrk24 · 2025-11-06T04:43:00Z

Fixes #233

Each backend has its own shortcomings:

UIKitBackend has weird availability constraints on each picker style, doesn't support hourMinuteAndSecond, and doesn't respect font color
- Furthermore, UIDatePicker doesn't exist on tvOS
AppKitBackend doesn't support the wheel picker style
WinUIBackend doesn't support hourMinuteAndSecond, doesn't respect font color, and doesn't respect environment.timeZone (instead always using the current time zone)
GtkBackend only supports the graphical picker style, doesn't respect environment.timeZone (instead always using the current time zone), and only supports picking the date, not the time
Gtk3Backend is unimplemented as I have no way to test it.

bbrk24 · 2025-11-06T23:57:03Z

The thought just occurred to me to observe NSSystemTimeZoneDidChange to properly redraw views that use @Environment(\.timeZone), but I'm unsure how that would work, and regardless I don't see an equivalent for the calendar.

stackotter · 2025-11-06T23:58:53Z

There’s a backend method called setEnvironmentChangeHandler or something like that. That’s where we currently observe system theme changes and would be where timezone observation should live as well.

bbrk24 · 2025-11-07T00:00:54Z

Right, I'll go see if I can get that to work in UIKitBackend and AppKitBackend first, and then maybe the other backends. I don't think it'll necessarily work on Linux though

bbrk24 · 2025-11-07T18:53:41Z

Marking this as draft because UIDatePicker (at least on iOS 17) completely misbehaves if the user changes the time zone in settings

stackotter

Thanks for this super detailed PR! Safari was lagging the entire time that I was reviewing your changes lol. I've left a bunch of requests and comments from an initial read through of all of the code.

I haven't had time to test out the changes myself yet, but I'll make sure to do that before merging and will update the PR with any additional feedback I have after testing things out.

Examples/Sources/DatePickerExample/DatePickerApp.swift

Sources/SwiftCrossUI/Environment/EnvironmentValues.swift

Sources/AppKitBackend/AppKitBackend.swift

Sources/SwiftCrossUI/Views/DatePicker.swift

Sources/UIKitBackend/UIKitBackend.swift

Sources/WinUIBackend/WinUIBackend.swift

stackotter

Now that the DatePicker example is relatively simple, I reckon it could make sense to merge it into ControlsExample.

Sources/SwiftCrossUI/Backend/AppBackend.swift

Sources/SwiftCrossUI/Environment/EnvironmentValues.swift

Sources/SwiftCrossUI/Views/DatePicker.swift

stackotter · 2025-12-13T03:40:58Z

I think I've gone through and closed all of the review comments that have been addressed and commented on ones that I have more questions about.

Regarding the GtkBackend TimePicker implementation: when I originally reviewed it I didn't realise that it's unused. If you'd like, feel free to turn my current comments on it into todo comments and document clearly that the class is neither ready nor used, and I'd count those comments as resolved. I more just want to avoid another contributor coming along and trying to use it assuming that it's meant to work properly in its current form.

stackotter

Somehow GitHub just had some of these comments pending from a while ago. I guess I must've left the review halfway through?

There's also this comment unresolved from a while ago: #244 (comment) . What do you reckon about that idea?

Looking good now though. Happy to merge once the GDateTime documentation comment is addressed and these changes have been rebased onto main.

Sources/Gtk/Utility/GDateTime.swift

Sources/SwiftCrossUI/Views/Modifiers/DatePickerStyleModifier.swift

Sources/UIKitBackend/UIKitBackend+Control.swift

Sources/SwiftCrossUI/Backend/AppBackend.swift

stackotter · 2026-01-06T01:54:03Z

I think you'll have to run ./generate.sh && ./format_and_lint.sh to fix those Gtk build issues. I changed some things about the generation

bbrk24 · 2026-01-07T02:42:05Z

Now that the DatePicker example is relatively simple, I reckon it could make sense to merge it into ControlsExample.

Done, and added a #if so that it can still run in Gtk3Backend (which doesn't implement pickers).

stackotter · 2026-01-07T02:48:57Z

Examples/Sources/ControlsExample/ControlsApp.swift

+                        VStack {
+                            Text("Selected date: \(date)")
+
+                            Picker(of: supportedDatePickerStyles, selection: $datePickerStyle)


Please put this in an HStack along with a label (like above for the flavour picker) so that it's clear what the picker is for

stackotter · 2026-01-07T02:50:34Z

Examples/Sources/ControlsExample/ControlsApp.swift

+
+                            Picker(of: supportedDatePickerStyles, selection: $datePickerStyle)
+
+                            DatePicker(


Please put the entirety of ControlsExample into a ScrollView because it's gotten pretty tall now (too tall for my laptop display). I probably should've done that a while ago

stackotter · 2026-01-07T04:17:04Z

I've just been testing out the ControlsExample on my various machines, and noticed that the GtkBackend really spams the time picker not implemented warning. It might be worth updating it to only log that message the first time it's triggered. I believe that one of the other backends has a mechanism to do that already, maybe UIKitBackend from some of Mia's changes?

Add DatePicker for AppKitBackend Add DatePickerExample to macOS CI Fix DatePicker update logic for AppKitBackend Update argument name to match SwiftUI Add more availability annotations Shut up tvOS let me see if the iOS CI will pass please work. Fine, here's your view Initial WinUI implementation Reformat WinUI code Implement minYear/maxYear for DatePicker Improve WinUI sizing code Fix CalendarDatePicker size Minor cleanup Generate GTK classes and improve manual type conversion oops Fix casing of calendar name Saving partial work on GtkBackend More partial work Use Gtk.Calendar Add missing parts to GtkBackend.updateDatePicker Add DatePickerExample to Linux CI Fix one Mac availability error Add availability annotation on unused widget Add time zone listener for UIKitBackend Add listener for AppKitBackend Address some PR comments Update some doc comments Support date-only pickers in AppKitBackend Change default timezone and calendar from autoupdatingCurrent to current Address more PR comments tvOS please compile first try Fixes after rebase Update GTK 4 bindings Update Gtk3 sources Update DummyBackend Address PR comments Add scroll view and implement range on GtkBackend Fix CI and add HStack

stackotter · 2026-01-07T05:34:49Z

When I click a day in the GtkBackend Calendar picker, it selects the day prior for some reason 🤔

stackotter · 2026-01-07T05:37:09Z

And when I click 'reset date to now', the focus ring stays on the date that I previously selected, rather than the programatically selected date. Maybe that's just a Gtk thing though?

stackotter

Thanks for your patience with this one 🙏

stackotter · 2026-01-09T08:37:52Z

I'll test locally while waiting for CI, then merge if all goes well.

stackotter · 2026-01-09T09:45:56Z

Damn, merging in the changes from main caused WinUIBackend compilation to fail. It appears to be because I moved the implementation of naturalSize to a static method for convenience when implementing WinUIElementRepresentable. This patch fixes things for me;

WinUIBackendFixes.patch

I also removed the picker's label because it was line wrapping and causing the date picker to be really tall with no visible reason when the window was skinny enough. I tried making the label fixedSize but for some reason that did nothing.

stackotter · 2026-01-09T09:48:43Z

And while testing on Windows I found that the graphical calendar view lets you unselect your selection without selecting anything else. I think in that case we should just programatically reselect the selected day again.

…t during merge

stackotter · 2026-01-11T02:56:29Z

Will merge once CI finishes (it got re-triggered because I had to resolve a merge conflict)

bbrk24 marked this pull request as draft November 7, 2025 18:53

bbrk24 marked this pull request as ready for review November 8, 2025 00:34

stackotter requested changes Nov 28, 2025

View reviewed changes

bbrk24 force-pushed the DatePicker branch from cb850f3 to f635983 Compare December 3, 2025 02:32

bbrk24 force-pushed the DatePicker branch from e1326b8 to 81f68e3 Compare December 11, 2025 03:58

bbrk24 requested a review from stackotter December 11, 2025 03:59

stackotter reviewed Dec 13, 2025

View reviewed changes

Sources/SwiftCrossUI/Backend/AppBackend.swift Outdated Show resolved Hide resolved

Sources/SwiftCrossUI/Environment/EnvironmentValues.swift Show resolved Hide resolved

Sources/SwiftCrossUI/Views/DatePicker.swift Outdated Show resolved Hide resolved

bbrk24 requested a review from stackotter December 19, 2025 02:25

stackotter requested changes Jan 2, 2026

View reviewed changes

bbrk24 force-pushed the DatePicker branch from 04628a7 to daa1082 Compare January 6, 2026 00:45

stackotter requested changes Jan 7, 2026

View reviewed changes

bbrk24 added 2 commits January 6, 2026 23:32

Bring debugLogOnce to GtkBackend

5abf0b5

bbrk24 force-pushed the DatePicker branch from fb06e4f to 5abf0b5 Compare January 7, 2026 04:35

Use local instead of UTC for GTK

0128d8b

bbrk24 requested a review from stackotter January 8, 2026 04:30

Merge branch 'main' into DatePicker

7e38325

stackotter previously approved these changes Jan 9, 2026

View reviewed changes

Fix WinUI DatePicker

a6b994b

bbrk24 dismissed stackotter’s stale review via a6b994b January 10, 2026 01:41

bbrk24 added 2 commits January 9, 2026 20:51

Merge remote-tracking branch 'upstream/main' into DatePicker

14d4573

Put back progress view resizing example after accidentally deleting i…

876316c

…t during merge

bbrk24 requested a review from stackotter January 10, 2026 02:51

stackotter previously approved these changes Jan 11, 2026

View reviewed changes

Merge branch 'main' into DatePicker

5384d4d

stackotter dismissed their stale review via 5384d4d January 11, 2026 02:55

stackotter approved these changes Jan 11, 2026

View reviewed changes

stackotter merged commit 425ff88 into moreSwift:main Jan 11, 2026
11 checks passed

stackotter mentioned this pull request Jan 11, 2026

DatePicker: Improve platform support parity #337

Open


		Picker(of: supportedDatePickerStyles, selection: $datePickerStyle)

		DatePicker(

Uh oh!

Date picker #244

Date picker #244

Uh oh!

Conversation

bbrk24 commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bbrk24 commented Nov 6, 2025

Uh oh!

stackotter commented Nov 6, 2025

Uh oh!

bbrk24 commented Nov 7, 2025

Uh oh!

bbrk24 commented Nov 7, 2025

Uh oh!

stackotter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stackotter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stackotter commented Dec 13, 2025

Uh oh!

stackotter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stackotter commented Jan 6, 2026

Uh oh!

bbrk24 commented Jan 7, 2026

Uh oh!

stackotter Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

stackotter Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

stackotter commented Jan 7, 2026

Uh oh!

stackotter commented Jan 7, 2026

Uh oh!

stackotter commented Jan 7, 2026

Uh oh!

stackotter left a comment

Choose a reason for hiding this comment

Uh oh!

stackotter commented Jan 9, 2026

Uh oh!

stackotter commented Jan 9, 2026

Uh oh!

stackotter commented Jan 9, 2026

Uh oh!

stackotter commented Jan 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bbrk24 commented Nov 6, 2025 •

edited

Loading